Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API integration example #212

Merged
merged 3 commits into from
Jul 2, 2019
Merged

REST API integration example #212

merged 3 commits into from
Jul 2, 2019

Conversation

mikz
Copy link
Contributor

@mikz mikz commented Jun 17, 2019

Cleanup authentication and fix Basic/Digest auth.

Provide example Sinatra application that implements our protocol.
Also, provide OpenAPI Specification for the API and documentation of how the protocol works.

Documentation for #186
/cc @vramosp @3scale/documentation

@mikz mikz force-pushed the rest-api-example branch 2 times, most recently from 79c4b01 to aba5247 Compare June 17, 2019 09:43
Copy link

@porueesq porueesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions.

@mikz mikz merged commit 1179be9 into master Jul 2, 2019
@mikz mikz deleted the rest-api-example branch July 2, 2019 11:06
@mikz mikz mentioned this pull request Jul 2, 2019
* `PUT /clients/:client_id` (create, update)
* `DELETE /clients/:client_id` (delete)

All endpoints must reply 2xx status code. Otherwise the request will be retried.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikz is there any limit on number of period of retries?

What if the DELETE responds with 404? I believe it can cause an infinite loop of trying to delete the non-existing client, e.g. https://issues.jboss.org/browse/THREESCALE-2206

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it should respond with 200 that the client is gone. It has exponential backoff and yes, there is some limit. It is the same for every object.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikz Can you please point me to the place where this is configured/set?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that for most tasks we are using the default https://github.com/chanks/que/blob/master/docs/error_handling.md#error-handling

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikz thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants